From 13f8cab3ed9782334b3ff25ea41fea734ea72419 Mon Sep 17 00:00:00 2001 From: aubert Date: Fri, 12 Jun 2026 01:25:15 +0200 Subject: [PATCH] =?UTF-8?q?bonne=20utilisation=20de=20nom=20de=20variable?= =?UTF-8?q?=20en=20anglais=20pour=20rester=20coh=C3=A9rent=20pour=20avis?= =?UTF-8?q?=20via=20la=20commande=20"find=20src/test/java/fr/iut=5Ffbleau/?= =?UTF-8?q?but3/dev62/mylibrary/review=20-name=20"*.java"=20-exec=20sed=20?= =?UTF-8?q?-i=20's/AVIS/REVIEW/g;=20s/Avis/Review/g;=20s/avis/review/g'=20?= =?UTF-8?q?{}=20+"=20pour=20les=20fichier=20test=20et=20remplacer=20le=20c?= =?UTF-8?q?hemin=20pour=20les=20fichier=20main?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../dev62/mylibrary/review/ReviewDTO.java | 2 +- .../review/converter/ReviewConverter.java | 1 + .../dev62/mylibrary/review/entity/Review.java | 4 +- .../exception/ReviewNotFoundException.java | 10 +-- .../review/repository/ReviewRepository.java | 12 ++-- .../review/usecase/ReviewUseCase.java | 50 ++++++------- .../review/converter/ReviewConverterTest.java | 2 +- .../mylibrary/review/entity/ReviewTest.java | 6 +- .../ReviewNotFoundExceptionTest.java | 22 +++--- .../repository/ReviewRepositoryTest.java | 34 ++++----- .../review/usecase/ReviewUseCaseTest.java | 70 +++++++++---------- 11 files changed, 107 insertions(+), 106 deletions(-) diff --git a/src/main/java/fr/iut_fbleau/but3/dev62/mylibrary/review/ReviewDTO.java b/src/main/java/fr/iut_fbleau/but3/dev62/mylibrary/review/ReviewDTO.java index f67097a..92e40ca 100644 --- a/src/main/java/fr/iut_fbleau/but3/dev62/mylibrary/review/ReviewDTO.java +++ b/src/main/java/fr/iut_fbleau/but3/dev62/mylibrary/review/ReviewDTO.java @@ -10,7 +10,7 @@ import java.util.UUID; @Builder public class ReviewDTO { - private UUID avisId; + private UUID reviewId; private UUID customerId; private UUID bookId; private Integer note; diff --git a/src/main/java/fr/iut_fbleau/but3/dev62/mylibrary/review/converter/ReviewConverter.java b/src/main/java/fr/iut_fbleau/but3/dev62/mylibrary/review/converter/ReviewConverter.java index a3fcea7..d8ebead 100644 --- a/src/main/java/fr/iut_fbleau/but3/dev62/mylibrary/review/converter/ReviewConverter.java +++ b/src/main/java/fr/iut_fbleau/but3/dev62/mylibrary/review/converter/ReviewConverter.java @@ -19,6 +19,7 @@ public class ReviewConverter { public static ReviewDTO toDTO(Review review) { return ReviewDTO.builder() + .reviewId(review.getReviewId()) .customerId(review.getCustomerId()) .bookId(review.getBookId()) .note(review.getNote()) diff --git a/src/main/java/fr/iut_fbleau/but3/dev62/mylibrary/review/entity/Review.java b/src/main/java/fr/iut_fbleau/but3/dev62/mylibrary/review/entity/Review.java index b295b5a..26b80ca 100644 --- a/src/main/java/fr/iut_fbleau/but3/dev62/mylibrary/review/entity/Review.java +++ b/src/main/java/fr/iut_fbleau/but3/dev62/mylibrary/review/entity/Review.java @@ -10,7 +10,7 @@ import java.util.UUID; @Builder public class Review { - private UUID avisId; + private UUID reviewId; private UUID customerId; private UUID bookId; private Integer note; @@ -18,7 +18,7 @@ public class Review { private LocalDate purchaseDate; public void setRandomUUID() { - this.avisId = UUID.randomUUID(); + this.reviewId = UUID.randomUUID(); } public void setRandomUUIDCustomerAndBook() { diff --git a/src/main/java/fr/iut_fbleau/but3/dev62/mylibrary/review/exception/ReviewNotFoundException.java b/src/main/java/fr/iut_fbleau/but3/dev62/mylibrary/review/exception/ReviewNotFoundException.java index b687a13..087454e 100644 --- a/src/main/java/fr/iut_fbleau/but3/dev62/mylibrary/review/exception/ReviewNotFoundException.java +++ b/src/main/java/fr/iut_fbleau/but3/dev62/mylibrary/review/exception/ReviewNotFoundException.java @@ -8,18 +8,18 @@ public class ReviewNotFoundException extends RuntimeException { public static final String THE_REVIEWS_WITH_CUSTOMER_ID_DOES_NOT_EXIST_MESSAGE = "The reviews with the customer id {0} does not exists"; public static final String THE_REVIEWS_WITH_BOOK_ID_DOES_NOT_EXIST_MESSAGE = "The reviews with the book id {0} does not exists"; - public static final String THE_REVIEWS_WITH_AVIS_ID_DOES_NOT_EXIST_MESSAGE = "The review with avis id {0} does not exists"; + public static final String THE_REVIEWS_WITH_REVIEW_ID_DOES_NOT_EXIST_MESSAGE = "The review with review id {0} does not exists"; - public ReviewNotFoundException(Optional customerUUID, Optional bookUUID, Optional avisUUID) { - super(buildMessage(customerUUID, bookUUID, avisUUID)); + public ReviewNotFoundException(Optional customerUUID, Optional bookUUID, Optional reviewUUID) { + super(buildMessage(customerUUID, bookUUID, reviewUUID)); } - private static String buildMessage(Optional customerUUID, Optional bookUUID, Optional avisUUID) { + private static String buildMessage(Optional customerUUID, Optional bookUUID, Optional reviewUUID) { if (customerUUID.isPresent()) { return MessageFormat.format(THE_REVIEWS_WITH_CUSTOMER_ID_DOES_NOT_EXIST_MESSAGE, customerUUID.get()); }else if (bookUUID.isPresent()) { return MessageFormat.format(THE_REVIEWS_WITH_BOOK_ID_DOES_NOT_EXIST_MESSAGE, bookUUID.get()); } - return MessageFormat.format(THE_REVIEWS_WITH_AVIS_ID_DOES_NOT_EXIST_MESSAGE, avisUUID.get()); + return MessageFormat.format(THE_REVIEWS_WITH_REVIEW_ID_DOES_NOT_EXIST_MESSAGE, reviewUUID.get()); } } diff --git a/src/main/java/fr/iut_fbleau/but3/dev62/mylibrary/review/repository/ReviewRepository.java b/src/main/java/fr/iut_fbleau/but3/dev62/mylibrary/review/repository/ReviewRepository.java index 203c931..378fceb 100644 --- a/src/main/java/fr/iut_fbleau/but3/dev62/mylibrary/review/repository/ReviewRepository.java +++ b/src/main/java/fr/iut_fbleau/but3/dev62/mylibrary/review/repository/ReviewRepository.java @@ -23,8 +23,8 @@ public class ReviewRepository { } public Review save(Review newReview) { - Optional optionalReviewWithSameAvisId = this.findByAvisId(newReview.getAvisId()); - optionalReviewWithSameAvisId.ifPresent(reviews::remove); + Optional optionalReviewWithSameReviewId = this.findByReviewId(newReview.getReviewId()); + optionalReviewWithSameReviewId.ifPresent(reviews::remove); this.reviews.add(newReview); return newReview; } @@ -41,9 +41,9 @@ public class ReviewRepository { .collect(Collectors.toCollection(ArrayList::new)); } - public Optional findByAvisId(UUID avisUUID) { + public Optional findByReviewId(UUID reviewUUID) { return this.reviews.stream() - .filter(review -> review.getAvisId().equals(avisUUID)) + .filter(review -> review.getReviewId().equals(reviewUUID)) .findFirst(); } @@ -57,9 +57,9 @@ public class ReviewRepository { .anyMatch(review -> review.getBookId().equals(bookUUID)); } - public boolean existsByAvisId(UUID avisUUID) { + public boolean existsByReviewId(UUID reviewUUID) { return this.reviews.stream() - .anyMatch(review -> review.getAvisId().equals(avisUUID)); + .anyMatch(review -> review.getReviewId().equals(reviewUUID)); } public void deleteCustomerReviews(UUID customerUUID) { diff --git a/src/main/java/fr/iut_fbleau/but3/dev62/mylibrary/review/usecase/ReviewUseCase.java b/src/main/java/fr/iut_fbleau/but3/dev62/mylibrary/review/usecase/ReviewUseCase.java index aa63f16..ddc80a5 100644 --- a/src/main/java/fr/iut_fbleau/but3/dev62/mylibrary/review/usecase/ReviewUseCase.java +++ b/src/main/java/fr/iut_fbleau/but3/dev62/mylibrary/review/usecase/ReviewUseCase.java @@ -26,7 +26,7 @@ public class ReviewUseCase { ReviewValidator.validate(newReview); Review reviewToRegister = ReviewConverter.toDomain(newReview); Review reviewToRegistered = reviewRepository.save(reviewToRegister); - return reviewToRegistered.getAvisId(); + return reviewToRegistered.getReviewId(); } public ArrayList findReviewByCustomerId(UUID customerId) { @@ -43,30 +43,30 @@ public class ReviewUseCase { .collect(Collectors.toCollection(ArrayList::new)); } - public Optional findReviewByAvisId(UUID avisId) { - Optional optionalReview = reviewRepository.findByAvisId(avisId); + public Optional findReviewByReviewId(UUID reviewId) { + Optional optionalReview = reviewRepository.findByReviewId(reviewId); return optionalReview.map(ReviewConverter::toDTO); } - public ReviewDTO updateReview(UUID avisUUID, ReviewInfo reviewInfo) + public ReviewDTO updateReview(UUID reviewUUID, ReviewInfo reviewInfo) throws ReviewNotFoundException, NotValidReviewException { ReviewValidator.validate(reviewInfo); - Review reviewByAvisUUID = getReviewIfDoesNotExistThrowReviewNotFoundException( - avisUUID); + Review reviewByReviewUUID = getReviewIfDoesNotExistThrowReviewNotFoundException( + reviewUUID); Review review = Review.builder() - .avisId(avisUUID) - .customerId(reviewByAvisUUID.getCustomerId()) - .bookId(reviewByAvisUUID.getBookId()) - .note(reviewByAvisUUID.getNote()) - .comment(reviewByAvisUUID.getComment()) - .purchaseDate(reviewByAvisUUID.getPurchaseDate()) + .reviewId(reviewUUID) + .customerId(reviewByReviewUUID.getCustomerId()) + .bookId(reviewByReviewUUID.getBookId()) + .note(reviewByReviewUUID.getNote()) + .comment(reviewByReviewUUID.getComment()) + .purchaseDate(reviewByReviewUUID.getPurchaseDate()) .build(); Review updatedReview = reviewRepository.save(review); return ReviewConverter.toDTO(updatedReview); } - public void deleteReview(UUID avisUUID) throws ReviewNotFoundException { - Review reviewToDelete = getReviewIfDoesNotExistThrowReviewNotFoundException(avisUUID); + public void deleteReview(UUID reviewUUID) throws ReviewNotFoundException { + Review reviewToDelete = getReviewIfDoesNotExistThrowReviewNotFoundException(reviewUUID); this.reviewRepository.delete(reviewToDelete); } @@ -84,30 +84,30 @@ public class ReviewUseCase { } } - private Review getReviewIfDoesNotExistThrowReviewNotFoundException(UUID avisUUID) + private Review getReviewIfDoesNotExistThrowReviewNotFoundException(UUID reviewUUID) throws ReviewNotFoundException { - Optional optionalReviewByAvisId = reviewRepository.findByAvisId(avisUUID); - if (optionalReviewByAvisId.isEmpty()) { - throw new ReviewNotFoundException(Optional.empty(), Optional.empty(),Optional.of(avisUUID)); + Optional optionalReviewByReviewId = reviewRepository.findByReviewId(reviewUUID); + if (optionalReviewByReviewId.isEmpty()) { + throw new ReviewNotFoundException(Optional.empty(), Optional.empty(),Optional.of(reviewUUID)); } - return optionalReviewByAvisId.get(); + return optionalReviewByReviewId.get(); } private ArrayList getReviewByCustomerIdIfDoesNotExistThrowReviewNotFoundException(UUID customerUUID) throws ReviewNotFoundException { - ArrayList optionalReviewByAvisId = reviewRepository.findByCustomerId(customerUUID); - if (optionalReviewByAvisId.isEmpty()) { + ArrayList optionalReviewByReviewId = reviewRepository.findByCustomerId(customerUUID); + if (optionalReviewByReviewId.isEmpty()) { throw new ReviewNotFoundException(Optional.of(customerUUID), Optional.empty(),Optional.empty()); } - return optionalReviewByAvisId; + return optionalReviewByReviewId; } private ArrayList getReviewByBookIfDoesNotExistThrowReviewNotFoundException(UUID bookUUID) throws ReviewNotFoundException { - ArrayList optionalReviewByAvisId = reviewRepository.findByBookId(bookUUID); - if (optionalReviewByAvisId.isEmpty()) { + ArrayList optionalReviewByReviewId = reviewRepository.findByBookId(bookUUID); + if (optionalReviewByReviewId.isEmpty()) { throw new ReviewNotFoundException(Optional.empty(), Optional.empty(), Optional.of(bookUUID)); } - return optionalReviewByAvisId; + return optionalReviewByReviewId; } } diff --git a/src/test/java/fr/iut_fbleau/but3/dev62/mylibrary/review/converter/ReviewConverterTest.java b/src/test/java/fr/iut_fbleau/but3/dev62/mylibrary/review/converter/ReviewConverterTest.java index 9e6c2ed..135ae7c 100644 --- a/src/test/java/fr/iut_fbleau/but3/dev62/mylibrary/review/converter/ReviewConverterTest.java +++ b/src/test/java/fr/iut_fbleau/but3/dev62/mylibrary/review/converter/ReviewConverterTest.java @@ -47,7 +47,7 @@ public class ReviewConverterTest { void shouldConvertReviewToDTO() { LocalDate purchaseDate = LocalDate.of(2026, 3, 24); Review review = Review.builder() - .avisId(UUID.randomUUID()) + .reviewId(UUID.randomUUID()) .customerId(UUID.randomUUID()) .bookId(UUID.randomUUID()) .note(5) diff --git a/src/test/java/fr/iut_fbleau/but3/dev62/mylibrary/review/entity/ReviewTest.java b/src/test/java/fr/iut_fbleau/but3/dev62/mylibrary/review/entity/ReviewTest.java index 132f5b4..44e78ea 100644 --- a/src/test/java/fr/iut_fbleau/but3/dev62/mylibrary/review/entity/ReviewTest.java +++ b/src/test/java/fr/iut_fbleau/but3/dev62/mylibrary/review/entity/ReviewTest.java @@ -38,17 +38,17 @@ public class ReviewTest { @DisplayName("setRandomUUID should change the ID to a new random UUID") void testSetRandomUUID() { Review review = Review.builder().build(); - UUID originalAvisId = review.getAvisId(); + UUID originalReviewId = review.getReviewId(); UUID originalCustomerId = review.getCustomerId(); UUID originalBookId = review.getCustomerId(); review.setRandomUUID(); review.setRandomUUIDCustomerAndBook(); - assertNotNull(review.getAvisId()); + assertNotNull(review.getReviewId()); assertNotNull(review.getCustomerId()); assertNotNull(review.getBookId()); - assertNotEquals(originalAvisId, review.getAvisId()); + assertNotEquals(originalReviewId, review.getReviewId()); assertNotEquals(originalCustomerId, review.getCustomerId()); assertNotEquals(originalBookId, review.getBookId()); } diff --git a/src/test/java/fr/iut_fbleau/but3/dev62/mylibrary/review/exception/ReviewNotFoundExceptionTest.java b/src/test/java/fr/iut_fbleau/but3/dev62/mylibrary/review/exception/ReviewNotFoundExceptionTest.java index f9c2951..9645ece 100644 --- a/src/test/java/fr/iut_fbleau/but3/dev62/mylibrary/review/exception/ReviewNotFoundExceptionTest.java +++ b/src/test/java/fr/iut_fbleau/but3/dev62/mylibrary/review/exception/ReviewNotFoundExceptionTest.java @@ -36,11 +36,11 @@ public class ReviewNotFoundExceptionTest { @Test @DisplayName("Exception message should contain the UUID provided for customer and book") void testExceptionMessageContainsUUIDForCustomerAndBook() { - UUID avisUUID = UUID.randomUUID(); + UUID reviewUUID = UUID.randomUUID(); - ReviewNotFoundException exception = new ReviewNotFoundException(Optional.empty(), Optional.empty(), Optional.of(avisUUID)); + ReviewNotFoundException exception = new ReviewNotFoundException(Optional.empty(), Optional.empty(), Optional.of(reviewUUID)); - String expectedMessage = String.format("The review with avis id %s does not exists", avisUUID); + String expectedMessage = String.format("The review with review id %s does not exists", reviewUUID); assertEquals(expectedMessage, exception.getMessage()); } @@ -73,25 +73,25 @@ public class ReviewNotFoundExceptionTest { @Test @DisplayName("Exception should use the correct constant message format for review") void testExceptionUsesConstantMessageReviewFormat() { - UUID avisUUID = UUID.randomUUID(); + UUID reviewUUID = UUID.randomUUID(); - ReviewNotFoundException exception = new ReviewNotFoundException(Optional.empty(), Optional.empty(), Optional.of(avisUUID)); + ReviewNotFoundException exception = new ReviewNotFoundException(Optional.empty(), Optional.empty(), Optional.of(reviewUUID)); - String expectedFormatWithPlaceholder = "The review with avis id {0} does not exists"; - assertEquals(ReviewNotFoundException.THE_REVIEWS_WITH_AVIS_ID_DOES_NOT_EXIST_MESSAGE, + String expectedFormatWithPlaceholder = "The review with review id {0} does not exists"; + assertEquals(ReviewNotFoundException.THE_REVIEWS_WITH_REVIEW_ID_DOES_NOT_EXIST_MESSAGE, expectedFormatWithPlaceholder); - assertTrue(exception.getMessage().contains(avisUUID.toString())); + assertTrue(exception.getMessage().contains(reviewUUID.toString())); } @Test @DisplayName("Exception should be properly thrown and caught") void testExceptionCanBeThrownAndCaught() { - UUID avisUUID = UUID.randomUUID(); + UUID reviewUUID = UUID.randomUUID(); try { - throw new ReviewNotFoundException(Optional.empty(),Optional.empty(), Optional.of(avisUUID)); + throw new ReviewNotFoundException(Optional.empty(),Optional.empty(), Optional.of(reviewUUID)); } catch (ReviewNotFoundException e) { - String expectedMessage = String.format("The review with avis id %s does not exists", avisUUID); + String expectedMessage = String.format("The review with review id %s does not exists", reviewUUID); assertEquals(expectedMessage, e.getMessage()); } } diff --git a/src/test/java/fr/iut_fbleau/but3/dev62/mylibrary/review/repository/ReviewRepositoryTest.java b/src/test/java/fr/iut_fbleau/but3/dev62/mylibrary/review/repository/ReviewRepositoryTest.java index d5da338..f4b5e4b 100644 --- a/src/test/java/fr/iut_fbleau/but3/dev62/mylibrary/review/repository/ReviewRepositoryTest.java +++ b/src/test/java/fr/iut_fbleau/but3/dev62/mylibrary/review/repository/ReviewRepositoryTest.java @@ -99,11 +99,11 @@ public class ReviewRepositoryTest { repository.save(review1); LocalDate purchaseDate = LocalDate.of(2026, 5, 24); - UUID avisId = review1.getAvisId(); + UUID reviewId = review1.getReviewId(); UUID customerId = UUID.randomUUID(); UUID bookId = UUID.randomUUID(); Review updatedReview = Review.builder() - .avisId(avisId) + .reviewId(reviewId) .customerId(customerId) .bookId(bookId) .note(4) @@ -114,7 +114,7 @@ public class ReviewRepositoryTest { Review savedReview = repository.save(updatedReview); assertEquals(1, repository.findAll().size()); - assertEquals(avisId, savedReview.getAvisId()); + assertEquals(reviewId, savedReview.getReviewId()); assertEquals(customerId, savedReview.getCustomerId()); assertEquals(bookId, savedReview.getBookId()); assertEquals(4, savedReview.getNote()); @@ -203,9 +203,9 @@ public class ReviewRepositoryTest { } @Test - @DisplayName("findByAvisId should return review with matching avis ID") - void testFindByAvisId() { - Optional foundreview = repository.findByAvisId(review1.getAvisId()); + @DisplayName("findByReviewId should return review with matching review ID") + void testFindByReviewId() { + Optional foundreview = repository.findByReviewId(review1.getReviewId()); assertTrue(foundreview.isPresent()); assertEquals(review1.getNote(), foundreview.get().getNote()); @@ -213,11 +213,11 @@ public class ReviewRepositoryTest { } @Test - @DisplayName("findByAvisId should return empty Optional when a review with avis ID doesn't exist") - void testFindByAvisIdNotFound() { - UUID nonExistentAvisId = UUID.randomUUID(); + @DisplayName("findByReviewId should return empty Optional when a review with review ID doesn't exist") + void testFindByReviewIdNotFound() { + UUID nonExistentReviewId = UUID.randomUUID(); - Optional foundreview = repository.findByAvisId(nonExistentAvisId); + Optional foundreview = repository.findByReviewId(nonExistentReviewId); assertTrue(foundreview.isEmpty()); } @@ -259,19 +259,19 @@ public class ReviewRepositoryTest { } @Test - @DisplayName("existsByAvisId should return true when a review with avis ID exists") - void testExistsByAvisIdExists() { - boolean exists = repository.existsByAvisId(review1.getAvisId()); + @DisplayName("existsByReviewId should return true when a review with review ID exists") + void testExistsByReviewIdExists() { + boolean exists = repository.existsByReviewId(review1.getReviewId()); assertTrue(exists); } @Test - @DisplayName("existsByAvisId should return false when avis ID doesn't exist") - void testExistsByAvisIdNotExists() { - UUID nonExistentAvisId = UUID.randomUUID(); + @DisplayName("existsByReviewId should return false when review ID doesn't exist") + void testExistsByReviewIdNotExists() { + UUID nonExistentReviewId = UUID.randomUUID(); - boolean exists = repository.existsByAvisId(nonExistentAvisId); + boolean exists = repository.existsByReviewId(nonExistentReviewId); assertFalse(exists); } diff --git a/src/test/java/fr/iut_fbleau/but3/dev62/mylibrary/review/usecase/ReviewUseCaseTest.java b/src/test/java/fr/iut_fbleau/but3/dev62/mylibrary/review/usecase/ReviewUseCaseTest.java index d10098d..61937b5 100644 --- a/src/test/java/fr/iut_fbleau/but3/dev62/mylibrary/review/usecase/ReviewUseCaseTest.java +++ b/src/test/java/fr/iut_fbleau/but3/dev62/mylibrary/review/usecase/ReviewUseCaseTest.java @@ -38,7 +38,7 @@ public class ReviewUseCaseTest { @InjectMocks private ReviewUseCase reviewUseCase; - private UUID avisId; + private UUID reviewId; private UUID customerId; private UUID bookId; private LocalDate purchaseDate; @@ -47,12 +47,12 @@ public class ReviewUseCaseTest { @BeforeEach void setUp() { - avisId = UUID.randomUUID(); + reviewId = UUID.randomUUID(); customerId = UUID.randomUUID(); bookId = UUID.randomUUID(); purchaseDate = LocalDate.of(2026, 5, 24); testReview = Review.builder() - .avisId(avisId) + .reviewId(reviewId) .customerId(customerId) .bookId(bookId) .note(2) @@ -75,7 +75,7 @@ public class ReviewUseCaseTest { UUID registeredId = reviewUseCase.registerReview(validReviewInfo); assertNotNull(registeredId); - assertEquals(avisId, registeredId); + assertEquals(reviewId, registeredId); verify(reviewRepository, times(1)).save(any(Review.class)); } @@ -148,28 +148,28 @@ public class ReviewUseCaseTest { } @Test - @DisplayName("Should return review when Avis ID exists") - void testFindReviewByAvisId() { - when(reviewRepository.findByAvisId(avisId)).thenReturn(Optional.of(testReview)); + @DisplayName("Should return review when Review ID exists") + void testFindReviewByReviewId() { + when(reviewRepository.findByReviewId(reviewId)).thenReturn(Optional.of(testReview)); - Optional foundReview = reviewUseCase.findReviewByAvisId(avisId); + Optional foundReview = reviewUseCase.findReviewByReviewId(reviewId); assertTrue(foundReview.isPresent()); assertEquals(testReview.getBookId(), foundReview.get().getBookId()); assertEquals(testReview.getNote(), foundReview.get().getNote()); - verify(reviewRepository, times(1)).findByAvisId(avisId); + verify(reviewRepository, times(1)).findByReviewId(reviewId); } @Test - @DisplayName("Should return empty Optional when avis ID doesn't exist") - void testFindReviewByAvisIdNotFound() { - UUID nonExistentAvisId = UUID.randomUUID(); - when(reviewRepository.findByAvisId(nonExistentAvisId)).thenReturn(Optional.empty()); + @DisplayName("Should return empty Optional when review ID doesn't exist") + void testFindReviewByReviewIdNotFound() { + UUID nonExistentReviewId = UUID.randomUUID(); + when(reviewRepository.findByReviewId(nonExistentReviewId)).thenReturn(Optional.empty()); - Optional foundReview = reviewUseCase.findReviewByAvisId(nonExistentAvisId); + Optional foundReview = reviewUseCase.findReviewByReviewId(nonExistentReviewId); assertTrue(foundReview.isEmpty()); - verify(reviewRepository, times(1)).findByAvisId(nonExistentAvisId); + verify(reviewRepository, times(1)).findByReviewId(nonExistentReviewId); } } @@ -180,11 +180,11 @@ public class ReviewUseCaseTest { @Test @DisplayName("Should update review when valid data is provided") void testUpdateReviewWithValidData() throws ReviewNotFoundException, NotValidReviewException { - when(reviewRepository.findByAvisId(avisId)).thenReturn(Optional.of(testReview)); + when(reviewRepository.findByReviewId(reviewId)).thenReturn(Optional.of(testReview)); LocalDate updatePurchaseDate = LocalDate.of(2026, 5, 30); Review updatedReview = Review.builder() - .avisId(avisId) + .reviewId(reviewId) .customerId(customerId) .bookId(bookId) .note(4) @@ -196,29 +196,29 @@ public class ReviewUseCaseTest { ReviewInfo updateInfo = new ReviewInfo(4, "en fait c'est bien", updatePurchaseDate); - ReviewDTO result = reviewUseCase.updateReview(avisId, updateInfo); + ReviewDTO result = reviewUseCase.updateReview(reviewId, updateInfo); assertNotNull(result); assertEquals(customerId, result.getCustomerId()); assertEquals(4, result.getNote()); assertEquals("en fait c'est bien", result.getComment()); - verify(reviewRepository, times(1)).findByAvisId(avisId); + verify(reviewRepository, times(1)).findByReviewId(reviewId); verify(reviewRepository, times(1)).save(any(Review.class)); } @Test - @DisplayName("Should throw exception when avis ID doesn't exist") + @DisplayName("Should throw exception when review ID doesn't exist") void testUpdateReviewNotFound() { - UUID nonExistentAvisId = UUID.randomUUID(); - when(reviewRepository.findByAvisId(nonExistentAvisId)).thenReturn(Optional.empty()); + UUID nonExistentReviewId = UUID.randomUUID(); + when(reviewRepository.findByReviewId(nonExistentReviewId)).thenReturn(Optional.empty()); LocalDate updatePurchaseDate = LocalDate.of(2026, 5, 24); ReviewInfo updateInfo = new ReviewInfo(3, "moyen", updatePurchaseDate); assertThrows(ReviewNotFoundException.class, - () -> reviewUseCase.updateReview(nonExistentAvisId, updateInfo)); + () -> reviewUseCase.updateReview(nonExistentReviewId, updateInfo)); - verify(reviewRepository, times(1)).findByAvisId(nonExistentAvisId); + verify(reviewRepository, times(1)).findByReviewId(nonExistentReviewId); verify(reviewRepository, never()).save(any(Review.class)); } @@ -229,9 +229,9 @@ public class ReviewUseCaseTest { ReviewInfo invalidUpdateInfo = new ReviewInfo(0, "éclaté au sol", updatePurchaseDate); assertThrows(NotValidReviewException.class, - () -> reviewUseCase.updateReview(avisId, invalidUpdateInfo)); + () -> reviewUseCase.updateReview(reviewId, invalidUpdateInfo)); - verify(reviewRepository, never()).findByAvisId(any(UUID.class)); + verify(reviewRepository, never()).findByReviewId(any(UUID.class)); verify(reviewRepository, never()).save(any(Review.class)); } } @@ -291,27 +291,27 @@ public class ReviewUseCaseTest { } @Test - @DisplayName("Should delete review when avis ID exists") + @DisplayName("Should delete review when review ID exists") void testDeleteReview() throws ReviewNotFoundException { - when(reviewRepository.findByAvisId(avisId)).thenReturn(Optional.of(testReview)); + when(reviewRepository.findByReviewId(reviewId)).thenReturn(Optional.of(testReview)); doNothing().when(reviewRepository).delete(testReview); - reviewUseCase.deleteReview(avisId); + reviewUseCase.deleteReview(reviewId); - verify(reviewRepository, times(1)).findByAvisId(avisId); + verify(reviewRepository, times(1)).findByReviewId(reviewId); verify(reviewRepository, times(1)).delete(testReview); } @Test - @DisplayName("Should throw exception when avis ID doesn't exist") + @DisplayName("Should throw exception when review ID doesn't exist") void testDeleteReviewNotFound() { - UUID nonExistentAvisId = UUID.randomUUID(); - when(reviewRepository.findByAvisId(nonExistentAvisId)).thenReturn(Optional.empty()); + UUID nonExistentReviewId = UUID.randomUUID(); + when(reviewRepository.findByReviewId(nonExistentReviewId)).thenReturn(Optional.empty()); assertThrows(ReviewNotFoundException.class, - () -> reviewUseCase.deleteReview(nonExistentAvisId)); + () -> reviewUseCase.deleteReview(nonExistentReviewId)); - verify(reviewRepository, times(1)).findByAvisId(nonExistentAvisId); + verify(reviewRepository, times(1)).findByReviewId(nonExistentReviewId); verify(reviewRepository, never()).delete(any(Review.class)); } }