From 20fafa1a1c98c575ad016f86578856d4f6e2bd8d Mon Sep 17 00:00:00 2001
From: aubert <marvin.aubert@etu.u-pec.fr>
Date: Wed, 10 Jun 2026 20:38:34 +0200
Subject: [PATCH] change a variable name to be more explicit

---
 .../review/converter/ReviewConverterTest.java | 22 ++++---------------
 1 file changed, 4 insertions(+), 18 deletions(-)

diff --git a/src/test/java/fr/iut_fbleau/but3/dev62/mylibrary/review/converter/ReviewConverterTest.java b/src/test/java/fr/iut_fbleau/but3/dev62/mylibrary/review/converter/ReviewConverterTest.java
index e7a0528..116a35e 100644
--- a/src/test/java/fr/iut_fbleau/but3/dev62/mylibrary/review/converter/ReviewConverterTest.java
+++ b/src/test/java/fr/iut_fbleau/but3/dev62/mylibrary/review/converter/ReviewConverterTest.java
@@ -24,8 +24,8 @@ public class ReviewConverterTest {
         @DisplayName("Should convert ReviewInfo to Review domain object")
         void shouldConvertReviewInfoToDomain() {
             // Given
-            LocalDate date = LocalDate.of(2026, 3, 24);
-            ReviewInfo reviewInfo = new ReviewInfo(5, "tres bon livre", date);
+            LocalDate purchaseDate = LocalDate.of(2026, 3, 24);
+            ReviewInfo reviewInfo = new ReviewInfo(5, "tres bon livre", purchaseDate);
 
             // When
             Review result = ReviewConverter.toDomain(reviewInfo);
@@ -45,13 +45,13 @@ public class ReviewConverterTest {
         @Test
         @DisplayName("Should convert Review domain object to ReviewDTO with all fields mapped correctly")
         void shouldConvertReviewToDTO() {
-            LocalDate date = LocalDate.of(2026, 3, 24);
+            LocalDate purchaseDate = LocalDate.of(2026, 3, 24);
             Review review = Review.builder()
                     .customerId(UUID.randomUUID())
                     .bookId(UUID.randomUUID())
                     .note(5)
                     .comment("très bon livre")
-                    .purchaseDate(date)
+                    .purchaseDate(purchaseDate)
                     .build();
 
             ReviewDTO result = ReviewConverter.toDTO(review);
@@ -64,18 +64,4 @@ public class ReviewConverterTest {
             assertEquals(review.getPurchaseDate(), result.getPurchaseDate());
         }
     }
-
-    @Test
-    @DisplayName("Should preserve empty string values during conversion")
-    void shouldPreserveEmptyStrings() {
-        LocalDate date = LocalDate.of(2026, 3, 24);
-        ReviewInfo reviewInfo = new ReviewInfo(5, "", date);
-
-        Review domainResult = ReviewConverter.toDomain(reviewInfo);
-        ReviewDTO dtoResult = ReviewConverter.toDTO(domainResult);
-
-        assertEquals(5, dtoResult.getNote());
-        assertEquals("", dtoResult.getComment());
-        assertEquals(date, dtoResult.getPurchaseDate());
-    }
 }