From e8563d44b169ced9db0d8af90d8a1cbf660a6772 Mon Sep 17 00:00:00 2001
From: felix-vi <patrick.felix-vimalaratnam@etu.u-pec.fr>
Date: Wed, 25 Mar 2026 10:56:04 +0100
Subject: [PATCH] =?UTF-8?q?:white=5Fcheck=5Fmark:=20Reussite=20du=20test?=
 =?UTF-8?q?=20de=20pr=C3=A9servation=20du=20champ=20string=20vide=20apr?=
 =?UTF-8?q?=C3=A8s=20les=20conversion?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../book/converter/BookConverter.java         |  4 ++--
 .../dev62/mylibrary/book/entity/Book.java     |  1 +
 .../book/converter/BookConverterTest.java     | 22 ++++++++++++++++++-
 3 files changed, 24 insertions(+), 3 deletions(-)

diff --git a/src/main/java/fr/iut_fbleau/but3/dev62/mylibrary/book/converter/BookConverter.java b/src/main/java/fr/iut_fbleau/but3/dev62/mylibrary/book/converter/BookConverter.java
index e3b9f97..5bb8efc 100644
--- a/src/main/java/fr/iut_fbleau/but3/dev62/mylibrary/book/converter/BookConverter.java
+++ b/src/main/java/fr/iut_fbleau/but3/dev62/mylibrary/book/converter/BookConverter.java
@@ -9,8 +9,8 @@ import fr.iut_fbleau.but3.dev62.mylibrary.book.entity.Book;
 public final class BookConverter {
     private BookConverter(){}
 
-    public static BookDTO ToDomain(BookInfo bookinfo, BookDetails bookdetails){
-        return BookDTO.builder()
+    public static Book ToDomain(BookInfo bookinfo, BookDetails bookdetails){
+        return Book.builder()
                 .isbn("0000000000000")
                 .title(bookinfo.title())
                 .author(bookinfo.author())
diff --git a/src/main/java/fr/iut_fbleau/but3/dev62/mylibrary/book/entity/Book.java b/src/main/java/fr/iut_fbleau/but3/dev62/mylibrary/book/entity/Book.java
index 4192245..8ddecb9 100644
--- a/src/main/java/fr/iut_fbleau/but3/dev62/mylibrary/book/entity/Book.java
+++ b/src/main/java/fr/iut_fbleau/but3/dev62/mylibrary/book/entity/Book.java
@@ -20,4 +20,5 @@ public class Book {
     private ArrayList<String> categories = new ArrayList<>();
     private String description ;
     private String language;
+
 }
diff --git a/src/test/java/fr/iut_fbleau/but3/dev62/mylibrary/book/converter/BookConverterTest.java b/src/test/java/fr/iut_fbleau/but3/dev62/mylibrary/book/converter/BookConverterTest.java
index 3b3231b..cd1731a 100644
--- a/src/test/java/fr/iut_fbleau/but3/dev62/mylibrary/book/converter/BookConverterTest.java
+++ b/src/test/java/fr/iut_fbleau/but3/dev62/mylibrary/book/converter/BookConverterTest.java
@@ -34,7 +34,7 @@ public class BookConverterTest {
                     .language("Français")
                     .build();
 
-            BookDTO result = BookConverter.ToDomain(bookinfo, bookdetails);
+            Book result = BookConverter.ToDomain(bookinfo, bookdetails);
 
             assertEquals(bookinfo.title(), result.getTitle());
             assertEquals(bookinfo.author(), result.getAuthor());
@@ -83,4 +83,24 @@ public class BookConverterTest {
             assertEquals(book.getLanguage(), result.getLanguage());
         }
     }
+
+    @Test
+    @DisplayName("Should preserve empty string values during conversion")
+    void shouldPreserveEmptyStrings() {
+        LocalDate date = LocalDate.of(2026, 3, 24);
+        BookInfo bookinfo = new BookInfo("La vie de Maxime", "Marvin Aubert", "Kioon", date);
+        ArrayList<String> categories = new ArrayList<>();
+        categories.add("Thriller");
+        categories.add("Biographie");
+        BookDetails bookdetails = BookDetails.builder()
+                .categories(categories)
+                .description("")
+                .language("Français")
+                .build();
+
+        Book book = BookConverter.ToDomain(bookinfo, bookdetails);
+        BookDTO result = BookConverter.ToDTO(book);
+
+        assertEquals("", result.getDescription());
+    }
 }