lebretonm/Projet_Pierront_Maxime_Marvin_Patrick
1
0
Fork 0
forked from pierront/mylibrary-template
Code Pull Requests Activity

change a variable name to be more explicit

Browse Source
This commit is contained in:
Marvin AUBERT
2026-06-10 20:38:34 +02:00
parent 77d79de12a
commit 20fafa1a1c
1 changed files with 4 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/test/java/fr/iut_fbleau/but3/dev62/mylibrary/review/converter/ReviewConverterTest.java
+4 -18
View File
@@ -24,8 +24,8 @@ public class ReviewConverterTest {
@DisplayName("Should convert ReviewInfo to Review domain object") @DisplayName("Should convert ReviewInfo to Review domain object")
void shouldConvertReviewInfoToDomain() { void shouldConvertReviewInfoToDomain() {
// Given // Given
LocalDate date = LocalDate.of(2026, 3, 24); LocalDate purchaseDate = LocalDate.of(2026, 3, 24);
ReviewInfo reviewInfo = new ReviewInfo(5, "tres bon livre", date); ReviewInfo reviewInfo = new ReviewInfo(5, "tres bon livre", purchaseDate);
// When // When
Review result = ReviewConverter.toDomain(reviewInfo); Review result = ReviewConverter.toDomain(reviewInfo);
@@ -45,13 +45,13 @@ public class ReviewConverterTest {
@Test @Test
@DisplayName("Should convert Review domain object to ReviewDTO with all fields mapped correctly") @DisplayName("Should convert Review domain object to ReviewDTO with all fields mapped correctly")
void shouldConvertReviewToDTO() { void shouldConvertReviewToDTO() {
LocalDate date = LocalDate.of(2026, 3, 24); LocalDate purchaseDate = LocalDate.of(2026, 3, 24);
Review review = Review.builder() Review review = Review.builder()
.customerId(UUID.randomUUID()) .customerId(UUID.randomUUID())
.bookId(UUID.randomUUID()) .bookId(UUID.randomUUID())
.note(5) .note(5)
.comment("très bon livre") .comment("très bon livre")
.purchaseDate(date) .purchaseDate(purchaseDate)
.build(); .build();
ReviewDTO result = ReviewConverter.toDTO(review); ReviewDTO result = ReviewConverter.toDTO(review);
@@ -64,18 +64,4 @@ public class ReviewConverterTest {
assertEquals(review.getPurchaseDate(), result.getPurchaseDate()); assertEquals(review.getPurchaseDate(), result.getPurchaseDate());
} }
} }
@Test
@DisplayName("Should preserve empty string values during conversion")
void shouldPreserveEmptyStrings() {
LocalDate date = LocalDate.of(2026, 3, 24);
ReviewInfo reviewInfo = new ReviewInfo(5, "", date);
Review domainResult = ReviewConverter.toDomain(reviewInfo);
ReviewDTO dtoResult = ReviewConverter.toDTO(domainResult);
assertEquals(5, dtoResult.getNote());
assertEquals("", dtoResult.getComment());
assertEquals(date, dtoResult.getPurchaseDate());
}
} }